Modified isJWT to use urlsafe base64 (also added) #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can fix the new merge conflicts? |
|
@profnandaa Resolved conflicts! |
profnandaa
added
the
🧹 needs-update
|
Can remove the unrelated changes from the diff, showing 32 files touched. Make sure you've rebased with the latest |
|
@profnandaa Sorry for that. Have fixed it. |
profnandaa
added
needs-more-review
and removed
🧹 needs-update
rubiin
requested changes
May 27, 2020
|
@profnandaa @rubiin Fixed it! Please check. |
profnandaa
reviewed
May 27, 2020
es/lib/isBase64.js
Outdated
| export default function isBase64(str) { | ||
| var options = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : {}; | ||
| var urlSafeBase64 = /^[A-Z0-9_\-]+$/i; | ||
| var default_base64_options = { |
There was a problem hiding this comment.
minor: for the camelCase consistency...
There was a problem hiding this comment.
Has been fixed now! @profnandaa
profnandaa
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handles conflicts in #1277
closes #964 and closes #962