Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(isPostalCode): add PR locale #1057

Merged
merged 1 commit into from
Jul 3, 2019
Merged

feat(isPostalCode): add PR locale #1057

merged 1 commit into from
Jul 3, 2019

Conversation

tevaum
Copy link
Contributor

@tevaum tevaum commented Jul 2, 2019

Adding Puerto Rico locale for isPostalCode

@profnandaa
Copy link
Member

Thanks for the PR, please do a rebuild and push again.

@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label Jul 3, 2019
profnandaa
profnandaa reviewed Jul 3, 2019
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just fix the merge conflict and we should be good 👍

@tevaum tevaum closed this Jul 3, 2019
@profnandaa
Copy link
Member

@tevaum -- just curious, why did you close this? 🤔

@tevaum
Copy link
Contributor Author

tevaum commented Jul 3, 2019 •
edited
Loading

Hummm.. I think the force-push I made closed this automatically :/

Should be good to go now. Thanks! ;)

@tevaum tevaum reopened this Jul 3, 2019
@profnandaa profnandaa merged commit 2f62084 into validatorjs:master Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tevaum @profnandaa