Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isMobilePhone fails ###-###-#### format #826

Closed
Kiran-N opened this issue May 3, 2018 · 2 comments
Closed

isMobilePhone fails ###-###-#### format #826

Kiran-N opened this issue May 3, 2018 · 2 comments
Labels
🙋‍♂️feature-request

Comments

@Kiran-N
Copy link

Kiran-N commented May 3, 2018

validator.isMobilePhone("###-###-####",'en-US') fails as a valid number.
@chriso
Copy link
Collaborator

chriso commented May 4, 2018

I'd be happy to accept a PR that relaxed the format to allow hyphens. Some of the other patterns already allow this. In the mean time, you can validate the results of phone.replace(/-/g, '') or use a custom regular expression pattern.

@tytoons tytoons mentioned this issue Jun 1, 2018
Closed
@brybrophy brybrophy mentioned this issue Jul 31, 2018
Merged
brybrophy added a commit to brybrophy/validator.js that referenced this issue Jul 31, 2018
@brybrophy
Add test case to satisfy validatorjs#826
c2ccf8d
@chriso
Copy link
Collaborator

chriso commented Jul 31, 2018

Fixed by #872

@chriso chriso closed this as completed Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🙋‍♂️feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chriso @Kiran-N