isURL marks valid URL as invalid

[AVVS]

http://mari--mari.ya.ru

.isURL marks this as invalid, though it works just fine

[blakehall]

isURL() also fails when there is http auth information in the url.

So something like http://username:[email protected] also fails.

[chriso]

@blakehall auth is supported.

/Volumes/Repositories/personal/validator.js (air) $ node
> var v = require('./');
undefined
> v.isURL('http://username:[email protected]');
true

[chriso]

Added in 3.15.0.

[blakehall]

@chriso Indeed, I mistakenly assumed it was an issue with http auth. It looks like the issue is actually with an underscore in our subdomain.

I'm trying to use this with our custom CI tool, which has urls like pr.example_com.294.example.com.

v.isURL('http://username:[email protected]_com.294.example.com') -> false
v.isURL('http://username:[email protected]') -> true

[chriso]

@blakehall I just pushed 3.16.0 with support for underscores in subdomains (via an option):

v.isURL('http://pr.example_com.294.example.com', {allow_underscores: true})
// => true

Previous discussion was in #242.

[blakehall]

cool! thanks for the pointer @chriso!

👍