Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isUrl fails for URLs that do not use domain suffixes #2448

Open
Woodz opened this issue Sep 9, 2024 · 1 comment
Open

isUrl fails for URLs that do not use domain suffixes #2448

Woodz opened this issue Sep 9, 2024 · 1 comment
Labels
🐛 bug

Comments

@Woodz
Copy link

Woodz commented Sep 9, 2024

Describe the bug
The following is a valid URL (according to w3c) but fails validation:

myapp://root/parent/child
@Woodz Woodz added the 🐛 bug label Sep 9, 2024
@ShreySinha02
Copy link

@Woodz isURL('myapp://root/parent/child',{protocols: ['myapp'],require_tld:false}) with these options it is passing validation

vivekmahindrakar added a commit to vivekmahindrakar/validator.js that referenced this issue Oct 20, 2024
@vivekmahindrakar
fix validatorjs#2448 : isUrl fails for URLs that do not use domain su…
132f1e2 
…ffixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Woodz @ShreySinha02