Allow floats like -.01, fixes #618

validatorjs · Feb 1, 2017 · cd92fb3 · cd92fb3
1 parent 0a5335c
commit cd92fb3
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,7 @@
 #### HEAD
 
+- Allow values like `-.01` in `isFloat()`
+  ([#618](https://github.com/chriso/validator.js/issues/618))
 - New locales
   ([#616](https://github.com/chriso/validator.js/pull/616))
 

diff --git a/lib/isFloat.js b/lib/isFloat.js
@@ -11,7 +11,7 @@ var _assertString2 = _interopRequireDefault(_assertString);
 
 function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }
 
-var float = /^(?:[-+]?(?:[0-9]+))?(?:\.[0-9]*)?(?:[eE][\+\-]?(?:[0-9]+))?$/;
+var float = /^(?:[-+])?(?:[0-9]+)?(?:\.[0-9]*)?(?:[eE][\+\-]?(?:[0-9]+))?$/;
 
 function isFloat(str, options) {
   (0, _assertString2.default)(str);

diff --git a/src/lib/isFloat.js b/src/lib/isFloat.js
@@ -1,6 +1,6 @@
 import assertString from './util/assertString';
 
-const float = /^(?:[-+]?(?:[0-9]+))?(?:\.[0-9]*)?(?:[eE][\+\-]?(?:[0-9]+))?$/;
+const float = /^(?:[-+])?(?:[0-9]+)?(?:\.[0-9]*)?(?:[eE][\+\-]?(?:[0-9]+))?$/;
 
 export default function isFloat(str, options) {
   assertString(str);

diff --git a/test/validators.js b/test/validators.js
@@ -1265,11 +1265,12 @@ describe('Validators', function () {
         '+0.123',
         '0.123',
         '.0',
+        '-.123',
+        '+.123',
         '01.123',
         '-0.22250738585072011e-307',
       ],
       invalid: [
-        '-.123',
         '  ',
         '',
         '.',

diff --git a/validator.js b/validator.js
@@ -695,7 +695,7 @@
         return regex.test(str) && minCheckPassed && maxCheckPassed && ltCheckPassed && gtCheckPassed;
       }
 
-      var float = /^(?:[-+]?(?:[0-9]+))?(?:\.[0-9]*)?(?:[eE][\+\-]?(?:[0-9]+))?$/;
+      var float = /^(?:[-+])?(?:[0-9]+)?(?:\.[0-9]*)?(?:[eE][\+\-]?(?:[0-9]+))?$/;
 
       function isFloat(str, options) {
         assertString(str);

diff --git a/validator.min.js b/validator.min.js