fix(toFloat): verify the string can be safely converted to a float (#…

…1226) This is needed because parseFloat('2020-01-06T14:31:00.135Z') will return 2020, even though it should return NaN. This fixes an issue checking isDivisibleBy('2020-01-06T14:31:00.135Z', 2).
validatorjs · Jan 7, 2020 · a77f767 · a77f767
1 parent ea39867
commit a77f767
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/src/lib/toFloat.js b/src/lib/toFloat.js
@@ -1,6 +1,7 @@
-import assertString from './util/assertString';
+import isFloat from './isFloat';
 
 export default function toFloat(str) {
-  assertString(str);
+  if (!isFloat(str)) return NaN;
+
   return parseFloat(str);
 }
diff --git a/test/sanitizers.js b/test/sanitizers.js
@@ -137,6 +137,7 @@ describe('Sanitizers', () => {
         '2.': 2.0,
         '-2.5': -2.5,
         '.5': 0.5,
+        '2020-01-06T14:31:00.135Z': NaN,
         foo: NaN,
       },
     });

diff --git a/test/validators.js b/test/validators.js
@@ -2335,6 +2335,8 @@ describe('Validators', () => {
         '',
         '.',
         'foo',
+        '20.foo',
+        '2020-01-06T14:31:00.135Z',
       ],
     });
 
@@ -3187,6 +3189,7 @@ describe('Validators', () => {
         '101',
         'foo',
         '',
+        '2020-01-06T14:31:00.135Z',
       ],
     });
   });