refactor: change api format to match other plugins #99

arturshadnik · 2024-07-17T22:40:16Z

Description

Refactor MaasValidatorSpec to match structure of other plugins
Modularize validator service
Break up MaaS api client into individual clients for each validator service
Update unit tests to match new structure

api/v1alpha1/maasvalidator_types.go

config/samples/maasvalidator-osimages.yaml

internal/controller/maasvalidator_controller.go

api/v1alpha1/maasvalidator_types.go

TylerGillson · 2024-07-17T23:26:51Z

@arturshadnik I removed the issue from the description, because otherwise merging this PR would close that issue, and this PR doesn't address it fully.

deps(deps): update module github.com/validator-labs/validator to v0.0.46 (#96) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/validator-labs/validator](https://togithub.com/validator-labs/validator) | `v0.0.44` -> `v0.0.46` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fvalidator-labs%2fvalidator/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fvalidator-labs%2fvalidator/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fvalidator-labs%2fvalidator/v0.0.44/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fvalidator-labs%2fvalidator/v0.0.44/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- <details> <summary>validator-labs/validator (github.com/validator-labs/validator)</summary> [`v0.0.46`](https://togithub.com/validator-labs/validator/releases/tag/v0.0.46) [Compare Source](https://togithub.com/validator-labs/validator/compare/v0.0.45...v0.0.46) - air-gapped support with Hauler ([#322](https://togithub.com/validator-labs/validator/issues/322)) ([4cd726d](https://togithub.com/validator-labs/validator/commit/4cd726d06d1de615e75117fcbcccc98b9142f782)) [`v0.0.45`](https://togithub.com/validator-labs/validator/releases/tag/v0.0.45) [Compare Source](https://togithub.com/validator-labs/validator/compare/v0.0.44...v0.0.45) - release 0.0.45 ([78f76a7](https://togithub.com/validator-labs/validator/commit/78f76a749eb139365c278fe3ef658a562927734f)) - **deps:** update softprops/action-gh-release digest to [`a74c6b7`](https://togithub.com/validator-labs/validator/commit/a74c6b7) ([#313](https://togithub.com/validator-labs/validator/issues/313)) ([262b5a0](https://togithub.com/validator-labs/validator/commit/262b5a05ecd0030492f21141053a9154836c22e8)) </details> --- 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/validator-labs/validator-plugin-maas).  --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Tyler Gillson <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tyler Gillson <[email protected]> style: update spec naming based on feedback style: update all docstrings to "MAAS" This aligns the documentation with Canonical's standard chore: delete redundant sample config style: MaaS => MAAS refactor: simplify maas api client and rewrite tests to match style: clean up code after rebase

deps(deps): update module github.com/validator-labs/validator to v0.0.46 (#96) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/validator-labs/validator](https://togithub.com/validator-labs/validator) | `v0.0.44` -> `v0.0.46` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fvalidator-labs%2fvalidator/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fvalidator-labs%2fvalidator/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fvalidator-labs%2fvalidator/v0.0.44/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fvalidator-labs%2fvalidator/v0.0.44/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- <details> <summary>validator-labs/validator (github.com/validator-labs/validator)</summary> [`v0.0.46`](https://togithub.com/validator-labs/validator/releases/tag/v0.0.46) [Compare Source](https://togithub.com/validator-labs/validator/compare/v0.0.45...v0.0.46) - air-gapped support with Hauler ([#322](https://togithub.com/validator-labs/validator/issues/322)) ([4cd726d](https://togithub.com/validator-labs/validator/commit/4cd726d06d1de615e75117fcbcccc98b9142f782)) [`v0.0.45`](https://togithub.com/validator-labs/validator/releases/tag/v0.0.45) [Compare Source](https://togithub.com/validator-labs/validator/compare/v0.0.44...v0.0.45) - release 0.0.45 ([78f76a7](https://togithub.com/validator-labs/validator/commit/78f76a749eb139365c278fe3ef658a562927734f)) - **deps:** update softprops/action-gh-release digest to [`a74c6b7`](https://togithub.com/validator-labs/validator/commit/a74c6b7) ([#313](https://togithub.com/validator-labs/validator/issues/313)) ([262b5a0](https://togithub.com/validator-labs/validator/commit/262b5a05ecd0030492f21141053a9154836c22e8)) </details> --- 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/validator-labs/validator-plugin-maas).  --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Tyler Gillson <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tyler Gillson <[email protected]> style: update spec naming based on feedback style: update all docstrings to "MAAS" This aligns the documentation with Canonical's standard chore: delete redundant sample config style: MaaS => MAAS refactor: simplify maas api client and rewrite tests to match style: clean up code after rebase chore: delete unused file

TylerGillson

couple more super minor nits.. looking good though!

internal/constants/constants.go

internal/validators/os/os_validator.go

also remove redundant comment style: add specific error msgs and val types for each validator

author arturshadnik <[email protected]> 1721255141 -0700 committer arturshadnik <[email protected]> 1721688964 -0700 refactor: change api format to match other plugins refactor: change api format to match other plugins deps(deps): update module github.com/validator-labs/validator to v0.0.46 (#96) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/validator-labs/validator](https://togithub.com/validator-labs/validator) | `v0.0.44` -> `v0.0.46` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fvalidator-labs%2fvalidator/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fvalidator-labs%2fvalidator/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fvalidator-labs%2fvalidator/v0.0.44/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fvalidator-labs%2fvalidator/v0.0.44/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- <details> <summary>validator-labs/validator (github.com/validator-labs/validator)</summary> [`v0.0.46`](https://togithub.com/validator-labs/validator/releases/tag/v0.0.46) [Compare Source](https://togithub.com/validator-labs/validator/compare/v0.0.45...v0.0.46) - air-gapped support with Hauler ([#322](https://togithub.com/validator-labs/validator/issues/322)) ([4cd726d](https://togithub.com/validator-labs/validator/commit/4cd726d06d1de615e75117fcbcccc98b9142f782)) [`v0.0.45`](https://togithub.com/validator-labs/validator/releases/tag/v0.0.45) [Compare Source](https://togithub.com/validator-labs/validator/compare/v0.0.44...v0.0.45) - release 0.0.45 ([78f76a7](https://togithub.com/validator-labs/validator/commit/78f76a749eb139365c278fe3ef658a562927734f)) - **deps:** update softprops/action-gh-release digest to [`a74c6b7`](https://togithub.com/validator-labs/validator/commit/a74c6b7) ([#313](https://togithub.com/validator-labs/validator/issues/313)) ([262b5a0](https://togithub.com/validator-labs/validator/commit/262b5a05ecd0030492f21141053a9154836c22e8)) </details> --- 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/validator-labs/validator-plugin-maas).  --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Tyler Gillson <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tyler Gillson <[email protected]> style: update spec naming based on feedback style: update all docstrings to "MAAS" This aligns the documentation with Canonical's standard chore: delete redundant sample config style: MaaS => MAAS refactor: simplify maas api client and rewrite tests to match style: clean up code after rebase refactor: change api format to match other plugins deps(deps): update module github.com/validator-labs/validator to v0.0.46 (#96) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/validator-labs/validator](https://togithub.com/validator-labs/validator) | `v0.0.44` -> `v0.0.46` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fvalidator-labs%2fvalidator/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fvalidator-labs%2fvalidator/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fvalidator-labs%2fvalidator/v0.0.44/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fvalidator-labs%2fvalidator/v0.0.44/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- <details> <summary>validator-labs/validator (github.com/validator-labs/validator)</summary> [`v0.0.46`](https://togithub.com/validator-labs/validator/releases/tag/v0.0.46) [Compare Source](https://togithub.com/validator-labs/validator/compare/v0.0.45...v0.0.46) - air-gapped support with Hauler ([#322](https://togithub.com/validator-labs/validator/issues/322)) ([4cd726d](https://togithub.com/validator-labs/validator/commit/4cd726d06d1de615e75117fcbcccc98b9142f782)) [`v0.0.45`](https://togithub.com/validator-labs/validator/releases/tag/v0.0.45) [Compare Source](https://togithub.com/validator-labs/validator/compare/v0.0.44...v0.0.45) - release 0.0.45 ([78f76a7](https://togithub.com/validator-labs/validator/commit/78f76a749eb139365c278fe3ef658a562927734f)) - **deps:** update softprops/action-gh-release digest to [`a74c6b7`](https://togithub.com/validator-labs/validator/commit/a74c6b7) ([#313](https://togithub.com/validator-labs/validator/issues/313)) ([262b5a0](https://togithub.com/validator-labs/validator/commit/262b5a05ecd0030492f21141053a9154836c22e8)) </details> --- 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/validator-labs/validator-plugin-maas).  --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Tyler Gillson <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tyler Gillson <[email protected]> style: update spec naming based on feedback style: update all docstrings to "MAAS" This aligns the documentation with Canonical's standard chore: delete redundant sample config style: MaaS => MAAS refactor: simplify maas api client and rewrite tests to match style: clean up code after rebase chore: delete unused file style: make constant name more meaningful also remove redundant comment style: add specific error msgs and val types for each validator refactor: change api format to match other plugins refactor: change api format to match other plugins deps(deps): update module github.com/validator-labs/validator to v0.0.46 (#96) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/validator-labs/validator](https://togithub.com/validator-labs/validator) | `v0.0.44` -> `v0.0.46` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fvalidator-labs%2fvalidator/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fvalidator-labs%2fvalidator/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fvalidator-labs%2fvalidator/v0.0.44/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fvalidator-labs%2fvalidator/v0.0.44/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- <details> <summary>validator-labs/validator (github.com/validator-labs/validator)</summary> [`v0.0.46`](https://togithub.com/validator-labs/validator/releases/tag/v0.0.46) [Compare Source](https://togithub.com/validator-labs/validator/compare/v0.0.45...v0.0.46) - air-gapped support with Hauler ([#322](https://togithub.com/validator-labs/validator/issues/322)) ([4cd726d](https://togithub.com/validator-labs/validator/commit/4cd726d06d1de615e75117fcbcccc98b9142f782)) [`v0.0.45`](https://togithub.com/validator-labs/validator/releases/tag/v0.0.45) [Compare Source](https://togithub.com/validator-labs/validator/compare/v0.0.44...v0.0.45) - release 0.0.45 ([78f76a7](https://togithub.com/validator-labs/validator/commit/78f76a749eb139365c278fe3ef658a562927734f)) - **deps:** update softprops/action-gh-release digest to [`a74c6b7`](https://togithub.com/validator-labs/validator/commit/a74c6b7) ([#313](https://togithub.com/validator-labs/validator/issues/313)) ([262b5a0](https://togithub.com/validator-labs/validator/commit/262b5a05ecd0030492f21141053a9154836c22e8)) </details> --- 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/validator-labs/validator-plugin-maas).  --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Tyler Gillson <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tyler Gillson <[email protected]> style: update spec naming based on feedback style: update all docstrings to "MAAS" This aligns the documentation with Canonical's standard chore: delete redundant sample config style: MaaS => MAAS refactor: simplify maas api client and rewrite tests to match style: clean up code after rebase refactor: change api format to match other plugins deps(deps): update module github.com/validator-labs/validator to v0.0.46 (#96) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/validator-labs/validator](https://togithub.com/validator-labs/validator) | `v0.0.44` -> `v0.0.46` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fvalidator-labs%2fvalidator/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fvalidator-labs%2fvalidator/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fvalidator-labs%2fvalidator/v0.0.44/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fvalidator-labs%2fvalidator/v0.0.44/v0.0.46?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- <details> <summary>validator-labs/validator (github.com/validator-labs/validator)</summary> [`v0.0.46`](https://togithub.com/validator-labs/validator/releases/tag/v0.0.46) [Compare Source](https://togithub.com/validator-labs/validator/compare/v0.0.45...v0.0.46) - air-gapped support with Hauler ([#322](https://togithub.com/validator-labs/validator/issues/322)) ([4cd726d](https://togithub.com/validator-labs/validator/commit/4cd726d06d1de615e75117fcbcccc98b9142f782)) [`v0.0.45`](https://togithub.com/validator-labs/validator/releases/tag/v0.0.45) [Compare Source](https://togithub.com/validator-labs/validator/compare/v0.0.44...v0.0.45) - release 0.0.45 ([78f76a7](https://togithub.com/validator-labs/validator/commit/78f76a749eb139365c278fe3ef658a562927734f)) - **deps:** update softprops/action-gh-release digest to [`a74c6b7`](https://togithub.com/validator-labs/validator/commit/a74c6b7) ([#313](https://togithub.com/validator-labs/validator/issues/313)) ([262b5a0](https://togithub.com/validator-labs/validator/commit/262b5a05ecd0030492f21141053a9154836c22e8)) </details> --- 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/validator-labs/validator-plugin-maas).  --------- Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: Tyler Gillson <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Tyler Gillson <[email protected]> style: update spec naming based on feedback style: update all docstrings to "MAAS" This aligns the documentation with Canonical's standard chore: delete redundant sample config style: MaaS => MAAS refactor: simplify maas api client and rewrite tests to match style: clean up code after rebase chore: delete unused file test: fix integration tests style: add comment style: remove extra comments

…idation' into feat/dns-validation

codecov · 2024-07-22T23:21:54Z

Codecov Report

Attention: Patch coverage is 68.53147% with 45 lines in your changes missing coverage. Please review.

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   45.83%   54.62%   +8.79%     
==========================================
  Files           5        5              
  Lines         288      335      +47     
==========================================
+ Hits          132      183      +51     
+ Misses        147      141       -6     
- Partials        9       11       +2

Files	Coverage Δ
api/v1alpha1/maasvalidator_types.go	`100.00% <100.00%> (ø)`
internal/validators/os/os_validator.go	`96.00% <96.00%> (ø)`
internal/controller/maasvalidator_controller.go	`73.56% <66.66%> (-6.93%)`	⬇️
api/v1alpha1/zz_generated.deepcopy.go	`44.07% <50.64%> (+5.61%)`	⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79092a1...986a354. Read the comment docs.

TylerGillson

Looks good! Just two little sections of duplicated code need to be removed.

internal/controller/maasvalidator_controller.go

🤖 I have created a release *beep* *boop* --- ## [0.0.5](v0.0.4...v0.0.5) (2024-07-26) ### Features * add upstream dns validation ([#102](#102)) ([50b317e](50b317e)) ### Bug Fixes * **deps:** update kubernetes packages to v0.30.1 ([#49](#49)) ([377eece](377eece)) * **deps:** update kubernetes packages to v0.30.2 ([#83](#83)) ([726a2ce](726a2ce)) * **deps:** update module github.com/go-logr/logr to v1.4.2 ([59edbe8](59edbe8)) * **deps:** update module github.com/maas/gomaasclient to v0.5.0 ([#74](#74)) ([26b3340](26b3340)) * **deps:** update module github.com/onsi/ginkgo/v2 to v2.19.0 ([61ecc09](61ecc09)) * **deps:** update module github.com/validator-labs/validator to v0.0.41 ([e0f3909](e0f3909)) * **deps:** update module github.com/validator-labs/validator to v0.0.42 ([#81](#81)) ([713d9f0](713d9f0)) * **deps:** update module github.com/validator-labs/validator to v0.0.43 ([929bc17](929bc17)) * **deps:** update module sigs.k8s.io/cluster-api to v1.7.3 ([052dee8](052dee8)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.18.4 ([a438000](a438000)) ### Other * **deps:** pin googleapis/release-please-action action to f3969c0 ([#67](#67)) ([9fef1b8](9fef1b8)) * **deps:** update actions/checkout digest to 0ad4b8f ([#61](#61)) ([7d40608](7d40608)) * **deps:** update actions/checkout digest to a5ac7e5 ([0d79ce6](0d79ce6)) * **deps:** update anchore/sbom-action action to v0.16.0 ([cd9bab3](cd9bab3)) * **deps:** update codecov/codecov-action digest to 125fc84 ([#69](#69)) ([3ae8c36](3ae8c36)) * **deps:** update dependency go to v1.22.4 ([#76](#76)) ([47fe6e2](47fe6e2)) * **deps:** update docker/login-action digest to 0d4c9c5 ([#70](#70)) ([6b0f1a2](6b0f1a2)) * **deps:** update docker/setup-buildx-action digest to d70bba7 ([#26](#26)) ([41c699c](41c699c)) * **deps:** update gcr.io/kubebuilder/kube-rbac-proxy docker tag to v0.16.0 ([#47](#47)) ([a53bf65](a53bf65)) * **deps:** update quay.io/validator-labs/validator-plugin-maas docker tag to v0.0.42 ([#80](#80)) ([3653e6e](3653e6e)) ### Dependency Updates * **deps:** update dependency go to v1.22.5 ([#92](#92)) ([b9cbe1d](b9cbe1d)) * **deps:** update kubernetes packages to v0.30.3 ([#98](#98)) ([8ae9189](8ae9189)) * **deps:** update module github.com/maas/gomaasclient to v0.6.0 ([#90](#90)) ([d00fb21](d00fb21)) * **deps:** update module github.com/onsi/ginkgo/v2 to v2.19.1 ([93815c3](93815c3)) * **deps:** update module github.com/onsi/gomega to v1.34.0 ([47cc390](47cc390)) * **deps:** update module github.com/validator-labs/validator to v0.0.44 ([e135801](e135801)) * **deps:** update module github.com/validator-labs/validator to v0.0.46 ([#96](#96)) ([3bb0e30](3bb0e30)) * **deps:** update module github.com/validator-labs/validator to v0.0.47 ([#100](#100)) ([addb5d0](addb5d0)) * **deps:** update module github.com/validator-labs/validator to v0.0.48 ([79092a1](79092a1)) * **deps:** update module github.com/validator-labs/validator to v0.0.49 ([ba024df](ba024df)) * **deps:** update module sigs.k8s.io/cluster-api to v1.7.4 ([0f646f9](0f646f9)) ### Refactoring * change api format to match other plugins ([#99](#99)) ([891a21b](891a21b)) * enable revive and address all lints ([#94](#94)) ([796238b](796238b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

enh: switch to using maps for az dedup fix: update unit tests for new error messages and to cover edge cases Signed-off-by: Artur Shad Nik deps(deps): update module github.com/onsi/ginkgo/v2 to v2.19.1 Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> ci: add reviewable-ext make target to update chart crds (#107) chore(main): release 0.0.5 (#66) :robot: I have created a release *beep* *boop* --- [0.0.5](v0.0.4...v0.0.5) (2024-07-26) * add upstream dns validation ([#102](#102)) ([50b317e](50b317e)) * **deps:** update kubernetes packages to v0.30.1 ([#49](#49)) ([377eece](377eece)) * **deps:** update kubernetes packages to v0.30.2 ([#83](#83)) ([726a2ce](726a2ce)) * **deps:** update module github.com/go-logr/logr to v1.4.2 ([59edbe8](59edbe8)) * **deps:** update module github.com/maas/gomaasclient to v0.5.0 ([#74](#74)) ([26b3340](26b3340)) * **deps:** update module github.com/onsi/ginkgo/v2 to v2.19.0 ([61ecc09](61ecc09)) * **deps:** update module github.com/validator-labs/validator to v0.0.41 ([e0f3909](e0f3909)) * **deps:** update module github.com/validator-labs/validator to v0.0.42 ([#81](#81)) ([713d9f0](713d9f0)) * **deps:** update module github.com/validator-labs/validator to v0.0.43 ([929bc17](929bc17)) * **deps:** update module sigs.k8s.io/cluster-api to v1.7.3 ([052dee8](052dee8)) * **deps:** update module sigs.k8s.io/controller-runtime to v0.18.4 ([a438000](a438000)) * **deps:** pin googleapis/release-please-action action to f3969c0 ([#67](#67)) ([9fef1b8](9fef1b8)) * **deps:** update actions/checkout digest to 0ad4b8f ([#61](#61)) ([7d40608](7d40608)) * **deps:** update actions/checkout digest to a5ac7e5 ([0d79ce6](0d79ce6)) * **deps:** update anchore/sbom-action action to v0.16.0 ([cd9bab3](cd9bab3)) * **deps:** update codecov/codecov-action digest to 125fc84 ([#69](#69)) ([3ae8c36](3ae8c36)) * **deps:** update dependency go to v1.22.4 ([#76](#76)) ([47fe6e2](47fe6e2)) * **deps:** update docker/login-action digest to 0d4c9c5 ([#70](#70)) ([6b0f1a2](6b0f1a2)) * **deps:** update docker/setup-buildx-action digest to d70bba7 ([#26](#26)) ([41c699c](41c699c)) * **deps:** update gcr.io/kubebuilder/kube-rbac-proxy docker tag to v0.16.0 ([#47](#47)) ([a53bf65](a53bf65)) * **deps:** update quay.io/validator-labs/validator-plugin-maas docker tag to v0.0.42 ([#80](#80)) ([3653e6e](3653e6e)) * **deps:** update dependency go to v1.22.5 ([#92](#92)) ([b9cbe1d](b9cbe1d)) * **deps:** update kubernetes packages to v0.30.3 ([#98](#98)) ([8ae9189](8ae9189)) * **deps:** update module github.com/maas/gomaasclient to v0.6.0 ([#90](#90)) ([d00fb21](d00fb21)) * **deps:** update module github.com/onsi/ginkgo/v2 to v2.19.1 ([93815c3](93815c3)) * **deps:** update module github.com/onsi/gomega to v1.34.0 ([47cc390](47cc390)) * **deps:** update module github.com/validator-labs/validator to v0.0.44 ([e135801](e135801)) * **deps:** update module github.com/validator-labs/validator to v0.0.46 ([#96](#96)) ([3bb0e30](3bb0e30)) * **deps:** update module github.com/validator-labs/validator to v0.0.47 ([#100](#100)) ([addb5d0](addb5d0)) * **deps:** update module github.com/validator-labs/validator to v0.0.48 ([79092a1](79092a1)) * **deps:** update module github.com/validator-labs/validator to v0.0.49 ([ba024df](ba024df)) * **deps:** update module sigs.k8s.io/cluster-api to v1.7.4 ([0f646f9](0f646f9)) * change api format to match other plugins ([#99](#99)) ([891a21b](891a21b)) * enable revive and address all lints ([#94](#94)) ([796238b](796238b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). deps(deps): update module github.com/validator-labs/validator to v0.0.50 Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

refactor: change api format to match other plugins

5c07fe1

arturshadnik requested a review from a team as a code owner July 17, 2024 22:40

arturshadnik requested a review from mattwelke July 17, 2024 22:40

Merge branch 'main' into feat/dns-validation

a68dbde

TylerGillson requested changes Jul 17, 2024

View reviewed changes

arturshadnik added 2 commits July 18, 2024 18:54

TylerGillson reviewed Jul 19, 2024

View reviewed changes

internal/constants/constants.go Outdated Show resolved Hide resolved

internal/constants/constants.go Outdated Show resolved Hide resolved

internal/validators/os/os_validator.go Outdated Show resolved Hide resolved

internal/validators/os/os_validator.go Outdated Show resolved Hide resolved

arturshadnik added 3 commits July 19, 2024 12:47

style: make constant name more meaningful

9912ac3

also remove redundant comment style: add specific error msgs and val types for each validator

chore: Merge remote-tracking branch 'refs/remotes/origin/feat/dns-val…

337bd95

…idation' into feat/dns-validation

TylerGillson requested changes Jul 23, 2024

View reviewed changes

internal/controller/maasvalidator_controller.go Outdated Show resolved Hide resolved

internal/controller/maasvalidator_controller.go Outdated Show resolved Hide resolved

TylerGillson and others added 2 commits July 22, 2024 19:06

Merge branch 'main' into feat/dns-validation

984b676

style: remove duplicate lines

986a354

TylerGillson approved these changes Jul 23, 2024

View reviewed changes

TylerGillson merged commit 891a21b into main Jul 23, 2024
8 checks passed

TylerGillson deleted the feat/dns-validation branch July 23, 2024 14:40

TylerGillson mentioned this pull request Jul 23, 2024

chore(main): release 0.0.5 #66

Merged

TylerGillson mentioned this pull request Aug 24, 2024

chore(main): release 0.0.1 #146

Closed

mattwelke mentioned this pull request Aug 24, 2024

chore(main): release 0.0.1 #148

Closed

TylerGillson mentioned this pull request Aug 24, 2024

chore(main): release 0.0.11 #150

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: change api format to match other plugins #99

refactor: change api format to match other plugins #99

arturshadnik commented Jul 17, 2024 •

edited by TylerGillson

Loading

TylerGillson commented Jul 17, 2024

TylerGillson left a comment

codecov bot commented Jul 22, 2024 •

edited

Loading

TylerGillson left a comment

refactor: change api format to match other plugins #99

refactor: change api format to match other plugins #99

Conversation

arturshadnik commented Jul 17, 2024 • edited by TylerGillson Loading

Description

TylerGillson commented Jul 17, 2024

TylerGillson left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 22, 2024 • edited Loading

Codecov Report

TylerGillson left a comment

Choose a reason for hiding this comment

arturshadnik commented Jul 17, 2024 •

edited by TylerGillson

Loading

codecov bot commented Jul 22, 2024 •

edited

Loading