Optionally allow for applications to be rolled out in an ordered fashion #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a sensible change. I'd probably rename wave to syncwave or something like that to make it a bit more explicit. Also add it to values.json.schema and maybe in one example |
|
Modified. @day0hero can you test that the comment is actually true? |
|
/lgtm |
|
👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure GitOps would have everything be infinitely declarative, however real life is messy and not all applications fit the declarative model. Rather than push the retries higher and higher, allow knowledgable authors to optionally define an order that applications should be rolled out in.