Skip to content

Commit

Permalink
We don't need managedClusterGroups to be global now we have a single …
Browse files Browse the repository at this point in the history
…chart consuming it
  • Loading branch information
beekhof committed Oct 3, 2022
1 parent fe78532 commit 9d4437e
Show file tree
Hide file tree
Showing 9 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion Changes.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Changes

## October 3, 2022
* Support both .Values.global.managedClusterGroups and the old .Values.clusterGroup.managedClusterGroups
* Support both .Values.managedClusterGroups and the old .Values.clusterGroup.managedClusterGroups
* Restore the ability to install a non-default site: `make TARGET_SITE=mysite install`
* Revised tests (new output and filenames, requires adding new result files to git)
* ACM 2.6 required for ACM-based managed sites
Expand Down
2 changes: 1 addition & 1 deletion managedClusters/templates/acm/multiclusterhub.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- $haveACM := false }}
{{- range coalesce .Values.global.managedClusterGroups .Values.clusterGroup.managedClusterGroups }}
{{- range coalesce .Values.managedClusterGroups .Values.clusterGroup.managedClusterGroups }}
{{- if not .hostedArgoSites }}
{{- $haveACM = true }}
{{- end }}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# TODO: Also create a GitOpsCluster.apps.open-cluster-management.io
{{- range coalesce .Values.global.managedClusterGroups .Values.clusterGroup.managedClusterGroups }}
{{- range coalesce .Values.managedClusterGroups .Values.clusterGroup.managedClusterGroups }}
{{- $group := . }}
{{- if not .hostedArgoSites }}
apiVersion: policy.open-cluster-management.io/v1
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- $haveACM := false }}
{{- range coalesce .Values.global.managedClusterGroups .Values.clusterGroup.managedClusterGroups }}
{{- range coalesce .Values.managedClusterGroups .Values.clusterGroup.managedClusterGroups }}
{{- if not .hostedArgoSites }}
{{- $haveACM = true }}
{{- end }}
Expand Down
4 changes: 2 additions & 2 deletions managedClusters/templates/acm/provision/clusterpool.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- range coalesce .Values.global.managedClusterGroups .Values.clusterGroup.managedClusterGroups }}
{{- range coalesce .Values.managedClusterGroups .Values.clusterGroup.managedClusterGroups }}
{{- $group := . }}
{{- if .clusterPools }}{{- /* We only create ManagedClusterSets if there are clusterPools defined */}}
apiVersion: cluster.open-cluster-management.io/v1beta1
Expand Down Expand Up @@ -84,4 +84,4 @@ spec:
{{- end }}{{- /* range .range clusters */}}
{{- end }}{{- /* range .clusterPools */}}
{{- end }}{{- /* if .clusterPools) */}}
{{- end }}{{- /* range coalesce .Values.global.managedClusterGroups .Values.clusterGroup.managedClusterGroups */}}
{{- end }}{{- /* range coalesce .Values.managedClusterGroups .Values.clusterGroup.managedClusterGroups */}}
2 changes: 1 addition & 1 deletion managedClusters/templates/acm/provision/secrets-aws.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- range coalesce .Values.global.managedClusterGroups .Values.clusterGroup.managedClusterGroups }}
{{- range coalesce .Values.managedClusterGroups .Values.clusterGroup.managedClusterGroups }}
{{- $group := . }}
{{- range .clusterPools }}
{{- $poolName := print .name "-" $group.name }}
Expand Down
2 changes: 1 addition & 1 deletion managedClusters/templates/acm/provision/secrets-azure.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- range coalesce .Values.global.managedClusterGroups .Values.clusterGroup.managedClusterGroups }}
{{- range coalesce .Values.managedClusterGroups .Values.clusterGroup.managedClusterGroups }}
{{- $group := . }}
{{- range .clusterPools }}
{{- $poolName := print .name "-" $group.name }}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- range coalesce .Values.global.managedClusterGroups .Values.clusterGroup.managedClusterGroups }}
{{- range coalesce .Values.managedClusterGroups .Values.clusterGroup.managedClusterGroups }}
{{- $group := . }}
{{- range .clusterPools }}
{{- $poolName := print .name "-" $group.name }}
Expand Down
2 changes: 1 addition & 1 deletion managedClusters/templates/argo/hosted-sites.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- range coalesce .Values.global.managedClusterGroups .Values.clusterGroup.managedClusterGroups }}
{{- range coalesce .Values.managedClusterGroups .Values.clusterGroup.managedClusterGroups }}
{{- $group := . }}
{{- if .hostedArgoSites }}
apiVersion: argoproj.io/v1alpha1
Expand Down

0 comments on commit 9d4437e

Please sign in to comment.