Upstream improvements from Lita fork #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tput which is useful for debugging
Improve error message of load_program_rom.
Morgan/issue/6
Remove `WRITE_ADVICE`.
Add signed division instruction
* lita-xyz/issue/15: wip: byte addressed program ROM * lita-xyz/issue/15: wip: byte addressed program ROM * lita-xyz/issue/15: wip: byte addressed program ROM * lita-xyz/issue/15: WIP: byte-addressed program ROM * Revert "lita-xyz/issue/15: WIP: byte-addressed program ROM" Explanation: pc values remain unchanged; they are just multiplied by 24 in the operands This reverts commit 371c65c. * lita-xyz/issue/15: no magic number * lita-xyz/issue/15: add comment * lita-xyz/issue/15: wip: fix tests * lita-xyz/issue/15: wip: fix STARK * lita-xyz/issue/15: fix STARK
|
There are a few issues, mainly the test failures, but I'm going to proceed with the merge and send a few followup PRs to address issues. |
This was referenced Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.