Fixes instances in inventory module where unnecessery updates happened #656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This pr attempts to solve some components that got triggered unnecessarily
can be observed with a simple system like this:
the above system will print each tick when an inventory is open, this will result in systems like the one above will trigger unnecessarily
Solution
To solve this I found the places where we currently "reset" some state in the inventory module each tick and replaced the modifications with alternatives that only trigger a modification if the value needed to be reset (was not in the reset state)