Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples and Tests for Templates #40

Merged
merged 13 commits into from
Nov 8, 2023
Merged

Examples and Tests for Templates #40

merged 13 commits into from
Nov 8, 2023

Conversation

valebes
Copy link
Owner

@valebes valebes commented Oct 24, 2023 •
edited
Loading

  • Add more docs for the templates module.
  • Add unit test for each template.

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023 •
edited by codecov bot
Loading

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (f05c3a5) 66.41% compared to head (91930ab) 76.98%.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main      #40       +/-   ##
===========================================
+ Coverage   66.41%   76.98%   +10.57%     
===========================================
  Files          13       13               
  Lines        1170     1182       +12     
===========================================
+ Hits          777      910      +133     
+ Misses        393      272      -121
Files Coverage Δ
src/pipeline/mod.rs 68.00% <ø> (ø)
src/thread_pool/mod.rs 95.30% <ø> (ø)
src/pipeline/node/inout_node.rs 64.37% <50.00%> (+0.59%) ⬆️
src/templates/map.rs 80.30% <50.00%> (+52.71%) ⬆️
src/templates/misc.rs 85.49% <88.57%> (+68.17%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@valebes valebes self-assigned this Oct 24, 2023
@valebes valebes marked this pull request as draft October 24, 2023 10:06
@valebes valebes requested a review from Della97 November 8, 2023 12:25
@valebes valebes marked this pull request as ready for review November 8, 2023 12:30
Della97
Della97 reviewed Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@Della97 Della97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all ok

Della97
Della97 reviewed Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@Della97 Della97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all ok

@valebes valebes requested a review from Della97 November 8, 2023 12:50
Della97
Della97 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@Della97 Della97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all ok

@valebes valebes merged commit 9a1d043 into main Nov 8, 2023
4 checks passed
@valebes valebes deleted the Examples branch November 8, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Della97 Della97 Della97 approved these changes

Assignees

@valebes valebes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valebes @codecov-commenter @Della97