Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1 adding linter #17

Merged
merged 4 commits into from
Jul 9, 2022
Merged

#1 adding linter #17

merged 4 commits into from
Jul 9, 2022

Conversation

pwnyprod
Copy link
Contributor

@pwnyprod pwnyprod commented Jul 8, 2022

Closing #1

Changes

Breaking changes

  • n/a

New / changed / removed

  • linter in ci

Improvements

  • n/a
Code Review

Code Review

What's part of a code review?

Readability & Maintainability

  • Code is not more complex than needed
  • Clear names are used (good naming practices)
  • Test coverage is sufficient and tests are well designed
  • Code has proper error handling

Documentation

  • Code is properly documented

Security & Performance

  • No obvious security flaws
  • No notable performance decrease

@pwnyprod pwnyprod linked an issue Jul 8, 2022 that may be closed by this pull request
CI/CD Integration #1
Closed
6 tasks
@pwnyprod pwnyprod merged commit 5a263a4 into main Jul 9, 2022
@pwnyprod pwnyprod deleted the #1-CI/CD_Integration branch July 14, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI/CD Integration
1 participant
@pwnyprod