Skip to content

Commit

Permalink
Add resources to our system components. (knative#2532)
Browse files Browse the repository at this point in the history
These values were determined from the graphs in the linked issue, which are from a knative/serving install running the e2e/conformance testing multiple times.

Fixes: knative#2393
  • Loading branch information
mattmoor authored and vagababov committed Nov 30, 2018
1 parent c3b8de1 commit b0d2550
Show file tree
Hide file tree
Showing 4 changed files with 36 additions and 0 deletions.
9 changes: 9 additions & 0 deletions config/activator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,15 @@ spec:
# and seeing k8s logs in addition to ours is not useful.
- "-logtostderr=false"
- "-stderrthreshold=FATAL"
resources:
# Request 2x what we saw running e2e
requests:
cpu: 20m
memory: 60Mi
# Limit to 10x the request (20x the observed peak during e2e)
limits:
cpu: 200m
memory: 600Mi
env:
- name: POD_NAME
valueFrom:
Expand Down
9 changes: 9 additions & 0 deletions config/autoscaler.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,15 @@ spec:
# This is the Go import path for the binary that is containerized
# and substituted here.
image: github.com/knative/serving/cmd/autoscaler
resources:
# Request 2x what we saw running e2e
requests:
cpu: 30m
memory: 40Mi
# Limit to 10x the request (20x the observed peak during e2e)
limits:
cpu: 300m
memory: 400Mi
ports:
- name: websocket
containerPort: 8080
Expand Down
9 changes: 9 additions & 0 deletions config/controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,15 @@ spec:
# This is the Go import path for the binary that is containerized
# and substituted here.
image: github.com/knative/serving/cmd/controller
resources:
# Request 2x what we saw running e2e
requests:
cpu: 100m
memory: 100Mi
# Limit to 10x the request (20x the observed peak during e2e)
limits:
cpu: 1000m
memory: 1000Mi
ports:
- name: metrics
containerPort: 9090
Expand Down
9 changes: 9 additions & 0 deletions config/webhook.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,15 @@ spec:
# This is the Go import path for the binary that is containerized
# and substituted here.
image: github.com/knative/serving/cmd/webhook
resources:
# Request 2x what we saw running e2e
requests:
cpu: 20m
memory: 20Mi
# Limit to 10x the request (20x the observed peak during e2e)
limits:
cpu: 200m
memory: 200Mi
volumeMounts:
- name: config-logging
mountPath: /etc/config-logging
Expand Down

0 comments on commit b0d2550

Please sign in to comment.