internal [202305] Add the pre_reboot_hook script execution, add the watchdog arm before the reboot
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadymhlushko-mlnx
force-pushed
the
202305-graceful-shutdown
branch
5 times, most recently
from
fa4ec22
to
35c42f7
Compare
scripts/reboot
Outdated
Comment on lines
251
to
267
| if [ -x ${DEVPATH}/${PLATFORM}/${PRE_REBOOT_HOOK} ]; then | ||
| debug "Executing the pre-reboot script" | ||
| ${DEVPATH}/${PLATFORM}/${PRE_REBOOT_HOOK} | ||
| fi |
There was a problem hiding this comment.
If this script fails we might want to abort the reboot operation (unless it is beeing forced).
Also, in case it fails, I wonder whether we should update reboot cause by above if block?
There was a problem hiding this comment.
Fixed.
The previous implementation also didn't change the reboot cause if it fails.
scripts/reboot
Outdated
| if [ -x ${DEVPATH}/${PLATFORM}/${PLAT_REBOOT} ]; then | ||
| VERBOSE=yes debug "Rebooting with platform ${PLATFORM} specific tool ..." | ||
| ${DEVPATH}/${PLATFORM}/${PLAT_REBOOT} $@ | ||
| ${DEVPATH}/${PLATFORM}/${PLAT_REBOOT} ${REBOOT_FLAGS} |
There was a problem hiding this comment.
I'd leave it as is, you might break someones flags.
vadymhlushko-mlnx
force-pushed
the
202305-graceful-shutdown
branch
2 times, most recently
from
fca7356
to
a7c2f2e
Compare
… --force flag bug Signed-off-by: vadymhlushko-mlnx <[email protected]>
vadymhlushko-mlnx
force-pushed
the
202305-graceful-shutdown
branch
from
a7c2f2e
to
2577790
Compare
stepanblyschak
approved these changes
Nov 30, 2023
vadymhlushko-mlnx
changed the title
vadymhlushko-mlnx
changed the title
pre_reboot_hook script execution, add the watchdog arm before the reboot
11 tasks
vadymhlushko-mlnx
force-pushed
the
202305-graceful-shutdown
branch
from
2577790
to
d58d529
Compare
vadymhlushko-mlnx
force-pushed
the
202305-graceful-shutdown
branch
from
d58d529
to
2577790
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Add the
pre_reboot_hookscript execution, add the watchdog arm before the reboot, in order to support thegraceful rebootinstead of the sysfs power cycle, to avoid filesystem corruption.How I did it
Modify the
scripts/rebootHow to verify it
show log -fandjournalctl -p debug -frebootcommand from the switch CLIPrevious command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)