Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle dark/light mode manually #129

Merged
merged 8 commits into from
Feb 7, 2022

Conversation

catalinmiron
Copy link
Contributor

Closes #125

@vadimdemedes I couldn't find a better name for the prop and I stick with theme, maybe you have a suggestion :)

@catalinmiron
Copy link
Contributor Author

@vadimdemedes any news on this? Thanks

Copy link
Owner

@vadimdemedes vadimdemedes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
source/tailwind-provider.tsx Outdated Show resolved Hide resolved
source/tailwind-provider.tsx Outdated Show resolved Hide resolved
source/tailwind-provider.tsx Outdated Show resolved Hide resolved
source/tailwind-provider.tsx Outdated Show resolved Hide resolved
source/tailwind-provider.tsx Outdated Show resolved Hide resolved
@catalinmiron
Copy link
Contributor Author

@vadimdemedes done. Please take another look.

PS: Thanks for the suggestions!

@vadimdemedes
Copy link
Owner

Great work, thank you!

@vadimdemedes vadimdemedes merged commit cbd5cd0 into vadimdemedes:master Feb 7, 2022
@vadimdemedes
Copy link
Owner

Thanks for review help, @HeleneGrini 👍

@catalinmiron
Copy link
Contributor Author

Thanks @vadimdemedes @HeleneGrini for the time! ❤️

@vadimdemedes
Copy link
Owner

Released in v4.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toggle dark mode manually
3 participants