-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor enhancements #135
Minor enhancements #135
Conversation
The changes in tests only fix the witness ordering.
No, pool registration still cannot be signed with a payment key as a pool owner (i.e. by a pyament and a staking key at the same time). Signing only with a payment key as the pool operator was allowed by the Ledger app (if I'm not mistaken), it just hasn't been supported by hw-cli. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a little refactor of isByronPath
, but LGTM. I've not run any tests, nor searched all the source code for missed items to rename etc.
The name was inaccurate (Byron account paths weren't covered).
For release notes 1.12.0:
that line is a bit misleading. the auxdata hash is kept if no auxiliary data is in the tx, and its corrected if the auxdata was reordered in canonical order. or is the auxdata not reordered anymore? |
Yes, that's the case. I can try to clarify that in the release notes. |
This PR fixes #120, #126, #131, #132, #134 and allows non-Plutus signing modes for txs with required signers. Most of the changes are rather small and simple, therefore only a single PR instead of six, but I recommend reviewing commit-by-commit.