spec/waku-discovery #99
Conversation
waku/waku.md
Outdated
| @@ -495,11 +495,9 @@ Notes useful for implementing Waku mode. | |||
|
|
|||
| ### Node discovery | |||
|
|
|||
| [Discovery v4](https://github.com/ethereum/devp2p/wiki/Discovery-Overview) SHOULD NOT be used, because it doesn't distinguish between capabilities. It will thus have a hard time finding Waku/Whisper nodes. | |||
| [Discovery v5](https://github.com/ethereum/devp2p/blob/master/discv5/discv5.md) MAY be used. However, it is quite bandwidth heavy for resource restricted devices. | |||
There was a problem hiding this comment.
Discovery v5 isn't finalized, so it would probably be a good idea to specify which version we are targeting
E.g. Draft of October 2019. (ethereum/devp2p@193bc09) (can be in a footnote if is too wordy)
There was a problem hiding this comment.
ah fair, I am not entirely sure of which version I think @adambabik or @cammellos can answer that.
There was a problem hiding this comment.
We use the deprecated version. It has been officially deprecated and it's not compliant with the current discv5 spec.
I would only keep info about EIP-1459 here.
There was a problem hiding this comment.
Ok, I could remove the entire discv5 stuff, @oskarth how do you feel?
There was a problem hiding this comment.
Since this is the Waku spec and not Status v1 reality, sure
* changed waku discovery * Update waku.md
This seems to cover it, @oskarth do you feel this requires more detail?