Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(59/STATUS-URL-DATA): initial draft #13

Merged
merged 10 commits into from
Sep 17, 2024
Merged

feat(59/STATUS-URL-DATA): initial draft #13

merged 10 commits into from
Sep 17, 2024

Conversation

jimstir
Copy link
Collaborator

@jimstir jimstir commented Feb 28, 2024

Moved from status-im/specs#169

Reference pull request: vacp2p/rfc#600

@jimstir
Copy link
Collaborator Author

jimstir commented May 29, 2024

Can this pr be closed @felicio?

@felicio
Copy link
Contributor

felicio commented May 29, 2024

@jimstir can you merge it instead?

@jimstir
Copy link
Collaborator Author

jimstir commented May 29, 2024

@felicio ok, it will be merged. Just FYI, raw specs are not assigned numbers.

name: Status URL Data
status: raw
category: Standards Track
tags: waku-application
Copy link
Contributor

@kaiserd kaiserd Jun 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this spec works on top of Waku its not a waku app protocol in waku domain... we could talk to Waku if we should use that tag here. Can also add it back in a future iteration.

@jimstir jimstir requested a review from kaiserd June 21, 2024 01:04
@felicio
Copy link
Contributor

felicio commented Sep 11, 2024

@jimstir please, what's needed for this to be merged like #14 was?

Also, seems like https://github.com/vacp2p/rfc-index/blob/main/vac/raw/url-scheme.md should have been moved to /status.

@jimstir
Copy link
Collaborator Author

jimstir commented Sep 11, 2024

@felicio Nothing else to do, this will be merged.

@jimstir
Copy link
Collaborator Author

jimstir commented Sep 12, 2024

@felicio Can you give this an approval then I will merge.

@felicio
Copy link
Contributor

felicio commented Sep 16, 2024

@jimstir please, what's needed for this to be merged like #14 was?

Also, seems like https://github.com/vacp2p/rfc-index/blob/main/vac/raw/url-scheme.md should have been moved to /status.

@jimstir please, did you move and reference the scheme spec? I don't see the change.

@jimstir
Copy link
Collaborator Author

jimstir commented Sep 16, 2024

@jimstir please, what's needed for this to be merged like #14 was?
Also, seems like https://github.com/vacp2p/rfc-index/blob/main/vac/raw/url-scheme.md should have been moved to /status.

@jimstir please, did you move and reference the scheme spec? I don't see the change.

I did this in a separate pr - #98.

Co-authored-by: Felicio Mununga <[email protected]>
@jimstir jimstir merged commit 36f64f0 into main Sep 17, 2024
2 checks passed
@jimstir jimstir deleted the feliciof/url-data branch September 17, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants