feat(17/WAKU-RLN-RELAY): add RLN credentials format #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
reviewed
Feb 29, 2024
| @@ -6,11 +6,12 @@ status: draft | |||
| tags: waku-core | |||
| editor: Sanaz Taheri <[email protected]> | |||
| contributors: | |||
| - Oskar Thorén <[email protected]> | |||
There was a problem hiding this comment.
I think Oskar wishes this email is used, not the status.im one
There was a problem hiding this comment.
@rymnc some of the pr being transferred from the old repo will not be updated. I have not looked over any of these, before merging everything should be checked.
| @@ -193,6 +183,43 @@ Below is the description of the fields of `RateLimitProof` and their types. | |||
| | `share_x` and `share_y`| array of 32 bytes each | Shamir secret shares of the user's secret identity key `sk` . `share_x` is the Poseidon hash of the `WakuMessage`'s `payload` concatenated with its `contentTopic` . `share_y` is calculated using [Shamir secret sharing scheme](/spec/32) | <!-- todo specify the poseidon hash setting --> | |||
| | `nullifier` | array of 32 bytes | internal nullifier derived from `epoch` and peer's `sk` as explained in [RLN construct](/spec/32)| | |||
|
|
|||
| ## RLN Credentials format | |||
There was a problem hiding this comment.
shouldn't this be in the waku keystore RFC?
|
Discussion continued on #32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes a JSON format for RLN credentials that can be easily generalized to different applications. It supports multi-groups for same (id_key, id_commitment) pair and multiple id pairs per application.
This PR addresses vacp2p/rfc#543
Reference pull request: vacp2p/rfc#550