chore: add support for i386 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomrsantos
force-pushed
the
add-support-for-i386
branch
5 times, most recently
from
206fddd to
62e7325
Compare
diegomrsantos
force-pushed
the
add-support-for-i386
branch
3 times, most recently
from
2d5a971 to
215912a
Compare
lchenut
reviewed
Sep 11, 2024
lchenut
reviewed
Sep 11, 2024
diegomrsantos
force-pushed
the
add-support-for-i386
branch
from
782f832 to
959086c
Compare
arnetheduck
reviewed
Sep 11, 2024
| @@ -2,7 +2,7 @@ import std/math | |||
| import pkg/stew/endians2 | |||
|
|
|||
| type | |||
| VarIntCompatible* = range[0..2^62-1] | |||
| VarIntCompatible* = range[0'i64..2'i64^62-1] | |||
There was a problem hiding this comment.
we generally avoid ranges: https://status-im.github.io/nim-style-guide/language.range.html
There was a problem hiding this comment.
It could be addressed in a new PR. What would you recommend in this case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reuses the
install_nimaction fromnim-libp2pto install Nimi386. We aren't running the test oni386- as GitHub runners are amd64, but only using Nimi386.It also uses
int64instead ofintforVarIntCompatibleandPacketNumberto supporti386.