Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): nim 2.0 dependency failure #1216

Merged
merged 12 commits into from
Oct 31, 2024
Merged

Conversation

AlejandroCabeza
Copy link
Collaborator

@AlejandroCabeza AlejandroCabeza commented Oct 16, 2024

Broken due to an update to Nimble 0.16.2 for the version-2-0 branch. This PR sets the ref to the previous commit. Also, updates the key naming so it fits better.

Nim's commit list: https://github.com/nim-lang/Nim/commits/version-2-0/

Important Note

In this PR some required job's names were changed. They need to be updated at repo-level so this PR can be merged.

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.51%. Comparing base (09fe199) to head (ba783f3).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1216      +/-   ##
==========================================
- Coverage   84.54%   84.51%   -0.03%     
==========================================
  Files          93       93              
  Lines       16650    16685      +35     
==========================================
+ Hits        14076    14101      +25     
- Misses       2574     2584      +10     

see 5 files with indirect coverage changes

Copy link
Collaborator

@kaiserd kaiserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This is a temp fix until we solve nim-lang/nimble#1277 solved.

@kaiserd
Copy link
Collaborator

kaiserd commented Oct 31, 2024

(finalizing this in a meeting)

@AlejandroCabeza AlejandroCabeza added this pull request to the merge queue Oct 31, 2024
Merged via the queue into master with commit 97192a3 Oct 31, 2024
14 checks passed
@AlejandroCabeza AlejandroCabeza deleted the fix/ci/nim-version branch October 31, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: done
Development

Successfully merging this pull request may close these issues.

3 participants