fix(ci): Daily workflows report #1200
Conversation
.github/workflows/daily_common.yml
Outdated
| @@ -60,7 +60,7 @@ jobs: | |||
|
|
|||
| name: '${{ matrix.platform.os }}-${{ matrix.cpu }} (Nim ${{ matrix.nim.branch }})' | |||
| runs-on: ${{ matrix.platform.builder }} | |||
| continue-on-error: ${{ matrix.nim.branch == 'devel' || matrix.nim.branch == 'version-2-0' }} | |||
| if: success() || failure() # Continue jobs even if previous jobs failed, but not if cancelled. | |||
There was a problem hiding this comment.
I'm not 100% sure this change will fix the problem. I just see that as a way to write continue-on-error differently. But I dig into this a bit too much and I think removing this line will solve the issue.
With fail-fast: false defined in the strategy up above, the jobs will not stop the whole pipeline on failure, even without this line (or the continue-on-error).
There was a problem hiding this comment.
I'm also not completely sure. But according to the post I mentioned in the description it apparently will do what it suggests.
I could set the daily jobs to run on PR so we can get the results here, now that I think about it.
There was a problem hiding this comment.
It seems it worked, as the jobs have been marked as failed? I can't say for sure, though.
There was a problem hiding this comment.
Could you try without this line, just for my own sanity? 😄
There was a problem hiding this comment.
Besides that, like you said, it seems it worked. Just remove the on pull_request and I approve it.
There was a problem hiding this comment.
The test runs finished a bit ago: Even though here the checks show as failed (with continue-on-error), if you check the Actions tab you'll see a difference between them. The workflows run with continue-on-error show as green tick (even if they failed), while the ones with the if: success() || failure() show as failed; which is the intended behaviour.
There was a problem hiding this comment.
I meant without continue-on-error and without if: success() || failure(). Sorry if I didn't make myself clear.
There was a problem hiding this comment.
Oh, I see. Doing that :)
There was a problem hiding this comment.
It seems to work without it.
There was a problem hiding this comment.
True. Shall we go for this?
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Fix daily workflows' green tick when jobs failed.
Based of off: https://stackoverflow.com/a/58859404
Closes: #1197