fix: create raceAndCancelPending proc #1175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegomrsantos
force-pushed
the
race-cancell
branch
from
a92c1bd
to
e21b0e4
Compare
AlejandroCabeza
approved these changes
Aug 27, 2024
diegomrsantos
changed the title
diegomrsantos
force-pushed
the
race-cancell
branch
from
0f3b94b
to
888385e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
raceproc in chronos doesn't cancel the remaining futures; sometimes that's what we need to do. This PR creates a proc that executes a race between a provided sequence of futures and cancels any remaining futures that have not yet been completed.Related to #1165 and #1170