Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Congo holidays #2037

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Add Congo holidays #2037

merged 1 commit into from
Oct 4, 2024

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Oct 4, 2024

Proposed change

Add Congo holidays with en_US, fr localization.

Resolves #1165 .

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Copy link

sonarqubecloud bot commented Oct 4, 2024

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7c69ef0) to head (2b19e14).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2037   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          189       190    +1     
  Lines        11486     11516   +30     
  Branches      1795      1797    +2     
=========================================
+ Hits         11486     11516   +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@arkid15r arkid15r added this pull request to the merge queue Oct 4, 2024
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff @PPsyrius
Thanks for adding another flag!

Merged via the queue into vacanza:dev with commit 318aa36 Oct 4, 2024
32 checks passed
@PPsyrius PPsyrius deleted the congo_holidays branch October 4, 2024 17:42
@arkid15r arkid15r mentioned this pull request Oct 7, 2024
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Congo holidays
3 participants