Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Saint Kitts & Nevis holidays #2005

Merged
merged 9 commits into from
Sep 23, 2024

Conversation

PPsyrius
Copy link
Collaborator

Proposed change

Add Saint Kitts and Nevis holidays (HALF_DAY, PUBLIC, WORKDAY).

Resolves #1261.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2a7442d) to head (f583fae).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #2005   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          188       189    +1     
  Lines        11409     11453   +44     
  Branches      1791      1794    +3     
=========================================
+ Hits         11409     11453   +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PPsyrius PPsyrius requested a review from KJhellico September 20, 2024 09:22
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree completely on the holidays, just a few small suggestions on the tests. :)

tests/countries/test_saint_kitts_and_nevis.py Outdated Show resolved Hide resolved
tests/countries/test_saint_kitts_and_nevis.py Outdated Show resolved Hide resolved
tests/countries/test_saint_kitts_and_nevis.py Outdated Show resolved Hide resolved
tests/countries/test_saint_kitts_and_nevis.py Outdated Show resolved Hide resolved
Copy link

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arkid15r arkid15r added this pull request to the merge queue Sep 23, 2024
Merged via the queue into vacanza:dev with commit f4a4195 Sep 23, 2024
32 checks passed
@PPsyrius PPsyrius deleted the saint_kitts_and_nevis_holidays branch September 27, 2024 13:50
@arkid15r arkid15r mentioned this pull request Oct 7, 2024
mstuttgart pushed a commit to multidadosti-erp/python-holidays that referenced this pull request Nov 18, 2024
Co-authored-by: ~Jhellico <[email protected]>
Co-authored-by: Arkadii Yakovets <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Saint Kitts and Nevis holidays
3 participants