-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Saint Kitts & Nevis holidays #2005
Add Saint Kitts & Nevis holidays #2005
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #2005 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 188 189 +1
Lines 11409 11453 +44
Branches 1791 1794 +3
=========================================
+ Hits 11409 11453 +44 ☔ View full report in Codecov by Sentry. |
Co-Authored-By: ~Jhellico <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree completely on the holidays, just a few small suggestions on the tests. :)
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: ~Jhellico <[email protected]> Co-authored-by: Arkadii Yakovets <[email protected]>
Proposed change
Add Saint Kitts and Nevis holidays (
HALF_DAY
,PUBLIC
,WORKDAY
).Resolves #1261.
Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally