Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dominica holidays #1956

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Add Dominica holidays #1956

merged 6 commits into from
Aug 28, 2024

Conversation

PPsyrius
Copy link
Collaborator

Proposed change

Add Dominica holidays.

Resolves #1172 .

Note

While Dominica's Public Holidays Act itself states that Labour Day falls on May, 1st, this has been de facto been observed on 1st Monday of May since at least 2010 continuously to the present (2024). As we cannot find the relevant amendments that caused that, we'll assume that the change started in 2010 for our current implementation.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e9c1b3d) to head (1d1bfd8).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #1956   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          187       188    +1     
  Lines        11382     11421   +39     
  Branches      1792      1794    +2     
=========================================
+ Hits         11382     11421   +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PPsyrius PPsyrius marked this pull request as ready for review August 28, 2024 02:58
tests/countries/test_dominica.py Outdated Show resolved Hide resolved
tests/countries/test_dominica.py Outdated Show resolved Hide resolved
@PPsyrius PPsyrius requested a review from KJhellico August 28, 2024 14:00
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, another country!

LGTM, just the naming suggestion:

tests/countries/test_dominica.py Outdated Show resolved Hide resolved
@PPsyrius PPsyrius requested a review from arkid15r August 28, 2024 18:15
Copy link

@arkid15r arkid15r enabled auto-merge August 28, 2024 19:36
@arkid15r arkid15r added this pull request to the merge queue Aug 28, 2024
Merged via the queue into vacanza:dev with commit a2aeae9 Aug 28, 2024
31 checks passed
@PPsyrius PPsyrius deleted the Dominica_holidays branch August 29, 2024 03:32
@KJhellico KJhellico mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Dominica holidays
3 participants