-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dominica holidays #1956
Add Dominica holidays #1956
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1956 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 187 188 +1
Lines 11382 11421 +39
Branches 1792 1794 +2
=========================================
+ Hits 11382 11421 +39 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, another country!
LGTM, just the naming suggestion:
Quality Gate passedIssues Measures |
Proposed change
Add Dominica holidays.
Resolves #1172 .
Note
While Dominica's Public Holidays Act itself states that Labour Day falls on
May, 1st
, this has been de facto been observed on1st Monday of May
since at least 2010 continuously to the present (2024). As we cannot find the relevant amendments that caused that, we'll assume that the change started in 2010 for our current implementation.Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally