Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Haiti holidays #1932

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Add Haiti holidays #1932

merged 6 commits into from
Aug 21, 2024

Conversation

PPsyrius
Copy link
Collaborator

Proposed change

Add Haiti holidays (en_US, es, fr_HT, ht).

Closes #1199.

Note

There's a list that claimed to be "official" from 1999 for cross-checking purposes here. As it doesn't match with our 2 modern Haitian sources, I'll probably keep it for future cross-reference instead should we manage to dig up additional legal references to make this more complete.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e3d0a35) to head (c43d57c).
Report is 4 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #1932   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          186       187    +1     
  Lines        11316     11367   +51     
  Branches      1789      1791    +2     
=========================================
+ Hits         11316     11367   +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

arkid15r
arkid15r previously approved these changes Aug 21, 2024
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

holidays/locale/fr_HT/LC_MESSAGES/HT.po Outdated Show resolved Hide resolved
Copy link

@arkid15r arkid15r added this pull request to the merge queue Aug 21, 2024
Merged via the queue into vacanza:dev with commit 3e50683 Aug 21, 2024
28 checks passed
@PPsyrius PPsyrius deleted the haiti_holidays branch August 22, 2024 00:47
@KJhellico KJhellico mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Haiti holidays
3 participants