-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Samoa holidays #1914
Add Samoa holidays #1914
Conversation
8c2fc41
to
1e141a9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1914 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 185 186 +1
Lines 11263 11289 +26
Branches 1785 1785
=========================================
+ Hits 11263 11289 +26 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kasya , it's great: 150 countries, a significant number! 👍
Please take a look at a few suggestions. :)
720f59c
to
bffcc14
Compare
@KJhellico Thanks for the review! 👍🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you @kasya!
@KJhellico is right -- 150 countries is a huge milestone! We move slowly but we make a good progress!
This LGTM, just needs make snapshot
update before the merge.
Quality Gate passedIssues Measures |
Proposed change
Add Samoa holidays
Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally