Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Samoa holidays #1914

Merged
merged 9 commits into from
Aug 15, 2024
Merged

Add Samoa holidays #1914

merged 9 commits into from
Aug 15, 2024

Conversation

kasya
Copy link
Contributor

@kasya kasya commented Aug 13, 2024

Proposed change

Add Samoa holidays

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@kasya kasya force-pushed the add-samoa-holidays branch from 8c2fc41 to 1e141a9 Compare August 13, 2024 02:12
Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (96823e8) to head (f41e6d8).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #1914   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          185       186    +1     
  Lines        11263     11289   +26     
  Branches      1785      1785           
=========================================
+ Hits         11263     11289   +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kasya kasya mentioned this pull request Aug 13, 2024
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kasya , it's great: 150 countries, a significant number! 👍
Please take a look at a few suggestions. :)

holidays/countries/samoa.py Outdated Show resolved Hide resolved
holidays/countries/samoa.py Outdated Show resolved Hide resolved
holidays/countries/samoa.py Outdated Show resolved Hide resolved
holidays/countries/samoa.py Outdated Show resolved Hide resolved
@kasya kasya force-pushed the add-samoa-holidays branch from 720f59c to bffcc14 Compare August 15, 2024 00:25
@kasya
Copy link
Contributor Author

kasya commented Aug 15, 2024

@kasya , it's great: 150 countries, a significant number! 👍 Please take a look at a few suggestions. :)

@KJhellico Thanks for the review! 👍🏼

KJhellico
KJhellico previously approved these changes Aug 15, 2024
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you @kasya!

@KJhellico is right -- 150 countries is a huge milestone! We move slowly but we make a good progress!

This LGTM, just needs make snapshot update before the merge.

Copy link

@arkid15r arkid15r enabled auto-merge August 15, 2024 22:18
@arkid15r arkid15r added this pull request to the merge queue Aug 15, 2024
Merged via the queue into vacanza:dev with commit 9b0c33a Aug 15, 2024
28 checks passed
@arkid15r arkid15r deleted the add-samoa-holidays branch August 15, 2024 22:27
This was referenced Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants