Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mauritania holidays #1884

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Add Mauritania holidays #1884

merged 2 commits into from
Jul 30, 2024

Conversation

kasya
Copy link
Contributor

@kasya kasya commented Jul 27, 2024

Proposed change

Add Mauritania holidays.

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

@kasya kasya requested review from arkid15r and KJhellico as code owners July 27, 2024 23:05
Copy link

codecov bot commented Jul 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fa3feb8) to head (5494437).

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #1884   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          184       185    +1     
  Lines        11194     11222   +28     
  Branches      1765      1766    +1     
=========================================
+ Hits         11194     11222   +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kasya, it's great work! There hasn't been new countries for a long time. Please take a look at few suggestions.

holidays/countries/mauritania.py Outdated Show resolved Hide resolved
tests/countries/test_mauritania.py Outdated Show resolved Hide resolved
Copy link

@KJhellico KJhellico linked an issue Jul 28, 2024 that may be closed by this pull request
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
thank you @kasya

@arkid15r arkid15r enabled auto-merge July 30, 2024 00:10
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@arkid15r arkid15r added this pull request to the merge queue Jul 30, 2024
Merged via the queue into vacanza:dev with commit 7d3c700 Jul 30, 2024
25 checks passed
@arkid15r arkid15r deleted the add-mauritania-holidays branch July 30, 2024 13:55
@KJhellico KJhellico mentioned this pull request Aug 5, 2024
@arkid15r arkid15r mentioned this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Mauritania holidays
3 participants