-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ghana holidays #1639
Add Ghana holidays #1639
Conversation
Pull Request Test Coverage Report for Build 7671158053Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JerryAgbesi thank you for implementing a new country support. The first one in 2024!
Please take a look at some improvement suggestions when you have a chance:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JerryAgbesi, new countries are always welcomed! 👍 Please take a look at a few suggestions.
Alright great, I'll add in the changes. Cheers 🥂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JerryAgbesi great work on the PR!
Please take a look at another round of my (mostly consistency enforcing) comments.
It seems it's good to go to beta after that 👍
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KJhellico I hope we can finally accept it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed change
Adds support for official public holidays observed in Ghana
closes #1191
Type of change
Checklist
make pre-commit
, it didn't generate any changesmake test
, all tests passed locally