Add Vanuatu holidays #1423
Merged
Add Vanuatu holidays #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5849122162
💛 - Coveralls |
KJhellico
reviewed
Aug 10, 2023
There was a problem hiding this comment.
@Strategos1 , thank you for adding new countries to Python Holidays! Please look at suggestions below.
holidays/countries/vanuatu.py
Outdated
Comment on lines
63
to
65
| if year >= 1981: | ||
| # Independence Day | ||
| self._add_holiday("Independence Day", JUL, 30) |
There was a problem hiding this comment.
Suggested change
| if year >= 1981: | |
| # Independence Day | |
| self._add_holiday("Independence Day", JUL, 30) | |
| # Independence Day | |
| self._add_holiday("Independence Day", JUL, 30) |
As we have no holidays until 1981.
holidays/countries/vanuatu.py
Outdated
| self._add_christmas_day("Christmas Day") | ||
|
|
||
| # Family day | ||
| self._add_holiday("Family Day", DEC, 26) |
There was a problem hiding this comment.
Suggested change
| self._add_holiday("Family Day", DEC, 26) | |
| self._add_christmas_day_two("Family Day") |
holidays/countries/vanuatu.py
Outdated
| # Website: https://github.com/dr-prodigy/python-holidays | ||
| # License: MIT (see LICENSE file) | ||
|
|
||
| from holidays.constants import FEB, MAR, JUL, OCT, NOV, DEC |
There was a problem hiding this comment.
Suggested change
| from holidays.constants import FEB, MAR, JUL, OCT, NOV, DEC | |
| from holidays.calendars.gregorian import FEB, MAR, JUL, OCT, NOV |
tests/countries/test_vanuatu.py
Outdated
Comment on lines
27
to
33
| def test_fater_lina_day(self): | ||
| name = "Father Lini Day" | ||
| self.assertHolidayName(name, (f"{year}-2-21" for year in range(1991, 2050))) | ||
| self.assertNoHolidayName(name, Vanuatu(years=range(1981, 1991))) | ||
| self.assertNoHoliday( | ||
| f"{year}-2-21" for year in set(range(1981, 1991)).difference({1982, 1984, 2085}) | ||
| ) |
There was a problem hiding this comment.
Suggested change
| def test_fater_lina_day(self): | |
| name = "Father Lini Day" | |
| self.assertHolidayName(name, (f"{year}-2-21" for year in range(1991, 2050))) | |
| self.assertNoHolidayName(name, Vanuatu(years=range(1981, 1991))) | |
| self.assertNoHoliday( | |
| f"{year}-2-21" for year in set(range(1981, 1991)).difference({1982, 1984, 2085}) | |
| ) | |
| def test_fater_lini_day(self): | |
| name = "Father Lini Day" | |
| self.assertHolidayName(name, (f"{year}-02-21" for year in range(1991, 2050))) | |
| self.assertNoHolidayName(name, Vanuatu(years=range(1981, 1991))) | |
| self.assertNoHoliday(f"{year}-02-21" for year in range(1981, 1991)) |
I don't see any reasons for exceptions for 1982, 1984.
There was a problem hiding this comment.
I copied a code from another country and forgot to change it. Sorry
arkid15r
reviewed
Aug 11, 2023
There was a problem hiding this comment.
lgtm, the code is clean and tested. If no comments regarding the calendar correctness I believe it's ready for merging into beta.
Thank you @Strategos1 for such a great contribution! Great work!
|
Merged into beta, thanks for extending the list of the supported countries 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Your PR description goes here.
Type of change
Checklist
betabranch of the repositorymake pre-commitmake test,make tox(we strongly encourage adding tests to your code)