-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add _add_childrens_day(...)
to InternationalHolidays
#1300
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkid15r
reviewed
Jun 12, 2023
PPsyrius
changed the title
Add
Add Jun 13, 2023
_add_childrens_day_jun1(...)
to InternationalHolidays
_add_childrens_day(...)
to InternationalHolidays
The suggestion is now implemented for wider support, though the coverall test seems dead for some reason, even if the local |
arkid15r
reviewed
Jun 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-Authored-By: Arkadii Yakovets <[email protected]>
It has been merged into beta. Now you can use it for Cambodia holidays ;) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR adds
_add_childrens_day(...)
toInternationalHolidays
, currently used by Romania, Moldova, and upcoming Cambodia (#1294) holiday support.The new
InternationalHolidays
is defaulted toJune 1
date, though another popular variation, November 20th is also supported viaself._add_childrens_day(name, NOV)
Type of change
Checklist
beta
branch of the repositorymake pre-commit
make test
,make tox
(we strongly encourage adding tests to your code)