Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _add_childrens_day(...) to InternationalHolidays #1300

Merged
merged 8 commits into from
Jun 16, 2023

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Jun 9, 2023

Proposed change

This PR adds _add_childrens_day(...) to InternationalHolidays, currently used by Romania, Moldova, and upcoming Cambodia (#1294) holiday support.

The new InternationalHolidays is defaulted to June 1 date, though another popular variation, November 20th is also supported via self._add_childrens_day(name, NOV)

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency upgrade (version update)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • This PR is filed against beta branch of the repository
  • This PR doesn't contain any merge conflicts and has clean commit history
  • The code style looks good: make pre-commit
  • All tests pass locally: make test, make tox (we strongly encourage adding tests to your code)
  • The related documentation has been added/updated (check off the box for free if no updates is required)

@coveralls
Copy link

coveralls commented Jun 9, 2023

Coverage Status

coverage: 100.0%. remained the same when pulling 52177be on PPsyrius:international_childrens_day into bf54ecd on dr-prodigy:beta.

@PPsyrius PPsyrius changed the title Add _add_childrens_day_jun1(...) to InternationalHolidays Add _add_childrens_day(...) to InternationalHolidays Jun 13, 2023
@PPsyrius
Copy link
Collaborator Author

The suggestion is now implemented for wider support, though the coverall test seems dead for some reason, even if the local tox test works perfectly.

@PPsyrius PPsyrius requested a review from arkid15r June 13, 2023 03:22
Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/test_holiday_groups.py Outdated Show resolved Hide resolved
tests/test_holiday_groups.py Outdated Show resolved Hide resolved
@arkid15r arkid15r added the ready for beta Ready to merge on beta branch label Jun 13, 2023
@PPsyrius PPsyrius requested a review from arkid15r June 14, 2023 03:29
@KJhellico KJhellico merged commit acc537f into vacanza:beta Jun 16, 2023
@KJhellico KJhellico removed the ready for beta Ready to merge on beta branch label Jun 16, 2023
@KJhellico
Copy link
Collaborator

It has been merged into beta. Now you can use it for Cambodia holidays ;)

@PPsyrius PPsyrius deleted the international_childrens_day branch June 16, 2023 14:31
@arkid15r arkid15r mentioned this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants