fix: do not close popover when it is just moved in DOM #8208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sissbruecker
commented
Nov 22, 2024
Comment on lines
+535
to
+541
| // Automatically close popover when it is removed from DOM | ||
| // Avoid closing if the popover is just moved in the DOM | ||
| queueMicrotask(() => { | ||
| if (!this.isConnected) { | ||
| this._openedStateController.close(true); | ||
| } | ||
| }); |
There was a problem hiding this comment.
This is adopted from notification:
web-components/packages/notification/src/vaadin-notification-mixin.js
Lines 255 to 259 in 003bbb3
Other components such as dialog also have logic for restoring the opened state, but I'm not sure if this is necessary at this point.
web-padawan
approved these changes
Nov 22, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
web-padawan
pushed a commit
that referenced
this pull request
Nov 22, 2024
Co-authored-by: Sascha Ißbrücker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a popover is immediately closed when it is disconnected from the DOM. That can be an issue in a Flow dialog when the popover is opened right away after adding it to the dialog. Here the element is first added as a child of the dialog, then opened, and afterwards moved to the dialog overlay by the renderer function. The last step causes the popover to close again.
This fixes the issue by delaying closing and checking if the element has been added to the DOM again. This is similar to what we are doing in other components such as dialog or notification.
Fixes vaadin/flow-components#6840