test: activate cell with Enter instead of double click #8202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
approved these changes
Nov 21, 2024
|
I've noticed this flakiness (same tests) on Chrome too, not as often as on FF though EDIT: Oh it happened with this PR also :) |
|
Right, that's problematic... I'll try to investigate this a bit more. It could be that these tests have been flaky since I changed them to use |
web-padawan
changed the title
|
Using Enter to activate the cell locally seems to work, let's see if this passes in CI. |
tomivirkki
approved these changes
Nov 21, 2024
|
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
web-padawan
added a commit
that referenced
this pull request
Nov 21, 2024
Co-authored-by: Serhii Kulykov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like using Enter instead of double click to activate the cell is more reliable.
Type of change