fix: prevent year scroller from getting focused in Chrome #8174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
reviewed
Nov 19, 2024
web-padawan
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
LGTM. Looks like this was introduced in Chrome 130, see the related blog post.
|
web-padawan
approved these changes
Nov 19, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
vursen
added a commit
that referenced
this pull request
Nov 19, 2024
) Co-authored-by: Sergey Vinogradov <[email protected]>
web-padawan
pushed a commit
that referenced
this pull request
Nov 19, 2024
) Co-authored-by: Sergey Vinogradov <[email protected]>
|
This ticket/PR has been released with Vaadin 24.6.0.beta1 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since Chrome 130, scrollable elements have become keyboard focusable by default. The PR prevents the date-picker year scroller from getting unexpectedly focused when navigating inside the overlay in Chrome.
Type of change