feat: grid-pro loading editor state (#8156) (CP: 24.4) #8166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
changed the title
|
@tomivirkki Looks like the tests are missing? |
Ah, good catch. Restored the tests. |
sissbruecker
approved these changes
Nov 18, 2024
|
|
||
| await sendKeys({ press: 'Tab' }); | ||
| const secondCellContent = getContainerCellContent(grid.$.items, 0, 1); | ||
| console.log(secondCellContent); |
There was a problem hiding this comment.
There's a log statement here that can probably be removed.
|
|
This ticket/PR has been released with Vaadin 24.4.18. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manually cherry-pick #8156 to
24.4