feat: add wrap theme to vertical-layout #8128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DiegoCardoso
commented
Nov 11, 2024
There was a problem hiding this comment.
When I tested it locally, the vaadin-vertical-layout element expanded horizontally to fit "Item 2" when it wrapped, but for some reason, it is not expanding here.
web-padawan
approved these changes
Nov 13, 2024
sissbruecker
approved these changes
Nov 13, 2024
|
This ticket/PR has been released with Vaadin 24.6.0.alpha4 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
wraptheme tovaadin-vertical-layoutthat simply sets theflex-wrapCSS property on the element towrap, allowing elements to move to the next line, if there's no space left.Part of #7949
Type of change