refactor: cleanup no longer needed date-time-picker logic #8091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
commented
Nov 5, 2024
| @@ -481,7 +474,6 @@ export const DateTimePickerMixin = (superClass) => | |||
|
|
|||
| // Disable default internal validation for the component | |||
| newDatePicker.validate = () => {}; | |||
| newDatePicker._validateInput = () => {}; | |||
There was a problem hiding this comment.
There is no such method anymore, this is a leftover from V14 version.
|
vursen
approved these changes
Nov 7, 2024
|
This ticket/PR has been released with Vaadin 24.6.0.alpha3 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed logic for propagating properties to default pickers since that is covered by individual observers since #4971. Some of these properties were removed in #4987 but not all of them, removed remaining ones and tests still pass.
Also removed logic for time-picker
valueupdate onminchange since we no longer adjust value based onminormaxsince V24 as of #4987 (the original logic was there since V14 version and is no longer needed).Also, updated logic for setting
i18non individual pickers to only set relevant properties using__syncI18n()method.Type of change