refactor: extract time-picker logic into reusable mixin #8079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tomivirkki
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracted most of
vaadin-time-pickerlogic intoTimePickerMixinfor reusing in Lit based version.Note:
ready()method isn't moved as the corresponding code in Lit has to be infirstUpdated().Otherwise there are problems with initial validation especially constraints observer triggered twice.
See also the Lit version of
vaadin-date-picker- IIRC the reason for not usingready()is the same:web-components/packages/date-picker/src/vaadin-lit-date-picker.js
Lines 112 to 113 in af1ab36
Type of change