Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update side-nav styles to use margin shorthand #7640

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

web-padawan
Copy link
Member

Description

Fixed two more warnings reported by upgrading to Stylelint 16:

packages/side-nav/theme/lumo/vaadin-side-nav-styles.js
  50:5  ✖  Expected shorthand property "margin-inline"  declaration-block-no-redundant-longhand-properties

packages/side-nav/theme/material/vaadin-side-nav-styles.js
  41:5  ✖  Expected shorthand property "margin-inline"  declaration-block-no-redundant-longhand-properties

Type of change

  • Refactor

Copy link

sonarcloud bot commented Aug 12, 2024

@web-padawan web-padawan merged commit 1590387 into main Aug 12, 2024
9 checks passed
@web-padawan web-padawan deleted the refactor/margin-shorthand branch August 12, 2024 08:45
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha10 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants