Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary event JSDoc from d.ts file #7541

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

web-padawan
Copy link
Member

Description

We only need @event annotation in .js files as Polymer Analyzer does not scan .d.ts files for it.
Removed this comment (there is a correct one in the corresponding .js file for this mixin.

Type of change

  • Documentation

@web-padawan web-padawan requested a review from vursen July 11, 2024 07:40
Copy link

sonarcloud bot commented Jul 11, 2024

@web-padawan web-padawan merged commit 99863ea into main Jul 11, 2024
9 checks passed
@web-padawan web-padawan deleted the chore/remove-incorrect-jsdoc branch July 11, 2024 08:44
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha5 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants