Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[menu-bar] Add possibility to disable roving tabindex #7525

Merged
merged 17 commits into from
Aug 12, 2024
Merged

[menu-bar] Add possibility to disable roving tabindex #7525

merged 17 commits into from
Aug 12, 2024

Commits on Aug 12, 2024

  1. 6718 [menu-bar] Add possibility to disable roving tabindex

    @jcgueriaud1 @web-padawan
    jcgueriaud1 authored and web-padawan committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    a746879 View commit details
    Browse the repository at this point in the history

  2. Revert the change in the demo

    @jcgueriaud1 @web-padawan
    jcgueriaud1 authored and web-padawan committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    00b28b3 View commit details
    Browse the repository at this point in the history

  3. Update the code to fix the navigation between submenus. Test to be done

    @jcgueriaud1 @web-padawan
    jcgueriaud1 authored and web-padawan committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    f7feea4 View commit details
    Browse the repository at this point in the history

  4. Test the navigation with tabs 

    Keep the submenu opened on tab navigation
    @jcgueriaud1 @web-padawan
    jcgueriaud1 authored and web-padawan committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    8904a90 View commit details
    Browse the repository at this point in the history

  5. Remove a useless import

    @jcgueriaud1 @web-padawan
    jcgueriaud1 authored and web-padawan committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    dff3c52 View commit details
    Browse the repository at this point in the history

  6. Copy the helpers from app-layout to menu-bar

    @jcgueriaud1 @web-padawan
    jcgueriaud1 authored and web-padawan committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    ee9d8ad View commit details
    Browse the repository at this point in the history

  7. Add the this._expandedButton !== null as a condition

    @jcgueriaud1 @web-padawan
    jcgueriaud1 authored and web-padawan committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    f3ebacb View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review

    @web-padawan
    web-padawan committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    e878d15 View commit details
    Browse the repository at this point in the history

  9. Update packages/menu-bar/src/vaadin-menu-bar-mixin.js

    @web-padawan
    web-padawan committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    8cd2fe5 View commit details
    Browse the repository at this point in the history

  10. Update packages/menu-bar/src/vaadin-menu-bar-mixin.js

    @web-padawan
    web-padawan committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    7dbb372 View commit details
    Browse the repository at this point in the history

  11. refactor: simplify menu-bar mixin code

    @web-padawan
    web-padawan committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    c6747ee View commit details
    Browse the repository at this point in the history

  12. test: add missing newline

    @web-padawan
    web-padawan committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    aa7452f View commit details
    Browse the repository at this point in the history

  13. test: split tests for switching submenu on Tab and Shift Tab

    @web-padawan
    web-padawan committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    88a809f View commit details
    Browse the repository at this point in the history

  14. test: inline sendKeys usage and remove helpers file

    @web-padawan
    web-padawan committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    b8e17d9 View commit details
    Browse the repository at this point in the history

  15. refactor: simplify if condition to remove nested block

    @web-padawan
    web-padawan committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    82699d8 View commit details
    Browse the repository at this point in the history

  16. docs: add comments to clarify switching submenu

    @web-padawan
    web-padawan committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    ef03904 View commit details
    Browse the repository at this point in the history

  17. test: add tabNavigation to typings test

    @web-padawan
    web-padawan committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    d0bba15 View commit details
    Browse the repository at this point in the history