Utility update #7515
Merged
Utility update #7515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
reviewed
Jul 5, 2024
web-padawan
reviewed
Jul 5, 2024
| @@ -15,106 +15,106 @@ export const background = css` | |||
| background-color: transparent; | |||
| } | |||
|
|
|||
| .bg-tint-5 { | |||
| background-color: var(--lumo-tint-5pct); | |||
| .bg-tint { | |||
There was a problem hiding this comment.
Not sure why this sorting is really needed but I would prefer to extract it from this PR, so as this would only be about adding new utility classes (easier to review and read it in the future).
There was a problem hiding this comment.
OCD. I wanted the LumoUtility classes and the actual CSS to line up. Easier to manage that way.
8 tasks
|
web-padawan
approved these changes
Jul 11, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
web-padawan
pushed a commit
that referenced
this pull request
Jul 18, 2024
Co-authored-by: Jonte Päivärinne <[email protected]>
|
This ticket/PR has been released with Vaadin 24.5.0.alpha5 and is also targeting the upcoming stable 24.5.0 version. |
This was referenced Aug 29, 2024
Closed
Closed
Merged
Merged
This was referenced Aug 31, 2024
Closed
Closed
Closed
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mostly just clean up (read: OCD sorting to match the
LumoUtilityclasses).flex-1per @marcushellberg's request.flex-grow/flex-shrinktogrow/shrinkrespectively (since we're following Tailwind's naming convention).z-0andz-autoadded.shadow-0added.Type of change
Checklist