feat: add ARIA attributes to popover overlay and target #7446
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of vaadin/platform#5271
Added the following attributes:
id
androle
on the overlayaria-haspopup
on the targetaria-controls
on the targetaria-expanded
on the targetAlso added properties to set accessible label:
accessibleName
to setaria-label
on the overlayaccessibleNameRef
to setaria-labelledby
on the overlayoverlayRole
property to setrole
on the overlayType of change
Note
Below are results of testing in VoiceOver & Chrome:
Button focused, overlay closed
Button focused, overlay opened
Popover overlay focused