Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ARIA attributes to popover overlay and target #7446

Merged
merged 5 commits into from
May 28, 2024

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented May 24, 2024

Description

Part of vaadin/platform#5271

Added the following attributes:

  • id and role on the overlay
  • aria-haspopup on the target
  • aria-controls on the target
  • aria-expanded on the target

Also added properties to set accessible label:

  • accessibleName to set aria-label on the overlay
  • accessibleNameRef to set aria-labelledby on the overlay
  • overlayRole property to set role on the overlay

Type of change

  • Feature

Note

Below are results of testing in VoiceOver & Chrome:

Button focused, overlay closed vo-chrome-1
Button focused, overlay opened vo-chrome-2 vo-chrome-3
Popover overlay focused vo-chrome-4

@web-padawan web-padawan requested a review from vursen May 24, 2024 11:38
Copy link

sonarcloud bot commented May 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@web-padawan web-padawan removed the request for review from vursen May 28, 2024 08:32
@web-padawan web-padawan merged commit bdabeea into main May 28, 2024
9 checks passed
@web-padawan web-padawan deleted the feat/popover-aria branch May 28, 2024 08:32
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants