feat: add properties to set popover content width and height #7442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
approved these changes
May 24, 2024
web-padawan
commented
May 24, 2024
There was a problem hiding this comment.
UPD: as discussed internally, decided to change contentWidth and contentHeight to be public:
I do think it would make sense to have in WC too. I suspect it's a lot more common to want to define a particular size to a popover, since you also position them in a particular way.
|
|
This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on #5187
Added API to set
vaadin-popoveroverlay content width and height:_contentWidthand_contentHeightproperties.These are marked as protected to align with
vaadin-confirm-dialog- see how the Flow counterpart uses them.Type of change