Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add focusDelay, hoverDelay and hideDelay to popover #7440

Merged
merged 3 commits into from
May 28, 2024

Conversation

web-padawan
Copy link
Member

Description

Added focusDelay, hoverDelay and hideDelay properties to the vaadin-popover.
These are similar to vaadin-tooltip with the exception of the following differences:

  • there is no common "warm up" and "cooldown" logic (we don't need to switch between popovers quickly)
  • there is no global API to set default hover, focus and hide delay values (can be added if we want to have it)
  • default hover, hide and focus delays in milliseconds are set to 0 (in vaadin-tooltip it's set to 500)

Type of change

  • Feature

@web-padawan web-padawan requested a review from vursen May 23, 2024 12:46
packages/popover/src/vaadin-popover.js Outdated Show resolved Hide resolved
packages/popover/src/vaadin-popover.js Outdated Show resolved Hide resolved
packages/popover/src/vaadin-popover.js Outdated Show resolved Hide resolved
packages/popover/src/vaadin-popover.js Outdated Show resolved Hide resolved
packages/popover/src/vaadin-popover.js Outdated Show resolved Hide resolved
packages/popover/src/vaadin-popover.js Show resolved Hide resolved
packages/popover/src/vaadin-popover.js Show resolved Hide resolved
Copy link

sonarcloud bot commented May 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@web-padawan web-padawan merged commit 64f6954 into main May 28, 2024
9 checks passed
@web-padawan web-padawan deleted the feat/popover-delay branch May 28, 2024 10:32
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants