Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not change value on step buttons touch scroll #6859

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

web-padawan
Copy link
Member

Description

Fixes #6857

Type of change

  • Bugfix

Before

Nov-27-2023.10-52-08.mp4

After

Nov-27-2023.10-53-29.mp4

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan merged commit a57bae7 into main Nov 27, 2023
9 checks passed
@web-padawan web-padawan deleted the fix/number-field-touchend-scroll branch November 27, 2023 09:14
@vaadin-bot
Copy link
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.1, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick a57bae7
error: could not apply a57bae7... fix: do not change value on step buttons touch scroll (#6859)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

web-padawan added a commit that referenced this pull request Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Number field step button click does not lock touch scrolling
3 participants