Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update text-area height on resize #6840

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

tomivirkki
Copy link
Member

Description

Fixes #1138

Before:

Kapture.2023-11-22.at.16.14.31.mp4

After:

Kapture.2023-11-22.at.16.14.58.mp4

Type of change

Bugfix

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tomivirkki tomivirkki merged commit be43f1c into main Nov 22, 2023
9 checks passed
@tomivirkki tomivirkki deleted the fix/text-area/update-height-on-resize branch November 22, 2023 14:22
@vaadin-bot
Copy link
Collaborator

Hi @tomivirkki and @tomivirkki, when i performed cherry-pick to this commit to 23.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick be43f1c
error: could not apply be43f1c... fix: update text-area height on resize (#6840)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @tomivirkki and @tomivirkki, when i performed cherry-pick to this commit to 23.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick be43f1c
error: could not apply be43f1c... fix: update text-area height on resize (#6840)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.3.0.beta1 and is also targeting the upcoming stable 24.3.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment